setup.py: fix version parsing on Python 3.14 (ast.Str removed)#589
setup.py: fix version parsing on Python 3.14 (ast.Str removed)#589sookach wants to merge 1 commit intohtml5lib:masterfrom
setup.py: fix version parsing on Python 3.14 (ast.Str removed)#589Conversation
|
This isn't right for pre-3.14 versions - the |
Python 3.14 removes the ast.Str node type. String literals now appear as ast.Constant(value=str). Update the AST check to accept both ast.Str (for older Pythons) and ast.Constant with a string value (for Python 3.8+), allowing html5lib to build successfully on Python 3.14 while remaining compatible with older version.
|
Thanks! Updated the PR. |
|
Could you fix appveyor? For example the flake8 formatting. setup.py declares python_requires >= 2.7, but Python 3.13 is not tested in appveyor. Python 3.7 is EOL since 2023-06-27, when will it be allowed to not stay compatible anymore?
Python 2.7 is EOL since 2020-01-01, when will it be allowed to not stay compatible anymore?
|
Python 3.14 removes the ast.Str node type. String literals now appear as ast.Constant(value=str).
Update the AST check to accept both ast.Str (for older Pythons) and ast.Constant with a string value (for Python 3.8+), allowing html5lib to build successfully on Python 3.14 while remaining compatible with older version. Tested at desk with
pip install -e .Fixes: #588